CDLUC3 / dmptool

DMPTool version of the DMPRoadmap codebase
https://dmptool.org
MIT License
56 stars 13 forks source link

Changes for Pilot project, the Finalize tab and the Public Pages search box #543

Closed briri closed 3 months ago

briri commented 3 months ago

@jupiter007 you can either merge this into your branch (and then include these changes in your PR) or, just copy the change made to the app/models/draft.rb file to your branch. That should allow the PDF URLs to come through to the UI.

github-actions[bot] commented 3 months ago
1 Error
:no_entry_sign:

Please include a CHANGELOG entry.

You can find it at [CHANGELOG.md](https://github.com/DMPRoadmap/roadmap/blob/main/CHANGELOG.md).
1 Warning
:warning: There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior. \n
Ignore this warning if the PR ONLY contains translation.io synced updates.

Generated by :no_entry_sign: Danger

briri commented 3 months ago

Good idea. The field already uses an aria-describedby that will display result info when they search. I added the text above it (within the aria-describedby block)

Screenshot 2024-03-15 at 8 56 23 AM