CDLUC3 / dmptool

DMPTool version of the DMPRoadmap codebase
https://dmptool.org
MIT License
56 stars 13 forks source link

Finish phase 1 dashboard work #574

Closed briri closed 4 weeks ago

briri commented 2 months ago

Add the final elements of the DMP Upload dashboard:

@fraserclark please make the PR to the v5 branch when you're ready

briri commented 1 month ago

Sorry for the delay in getting a sample of what the related works JSON looks like to you.

Here is a recent DMP one of our pilot project partners uploaded through the phase 1 functionality. It has 8 related works that need review: https://api.dmphub.uc3prd.cdlib.net/dmps/10.48321/D13BEA529C

The related works can be found in the dmphub_modifications array

fraserclark commented 1 month ago

@briri I've added the pull request now

https://github.com/CDLUC3/dmptool/pull/589

briri commented 1 month ago

@fraserclark I merged your PR and then needed to make a few minor adjustments to the way related_works were being checked/handled and also with the grant_id. I think maybe you had old data on your local or were working with some older registered plans that had some outdated metadata.

For reference, those changes are in my PR #594 no need for you to do anything with it, just an FYI

mariapraetzellis commented 1 month ago

My notes from testing the slider:

  1. I have 3 small formatting & text changes:
    • Increase the margins of the Grant ID field. It is currently displaying too close to the right margin of the slider. Screen Shot 2024-05-21 at 1 15 26 PM
  1. Is it possible to add an "X" to close the slider window so you don’t have to scroll to the bottom in order to close the window?

  2. I found one possible bug. I created a new plan via the upload feature but did not generate a DMP ID. Howver, there is still a DMP ID included in the slider. https://dmptool-stg.cdlib.org/dashboard/dmp/20240521-2394df1c2e33

briri commented 1 month ago

@jupiter007 I just pushed the changes Maria request to my PR #594. Can you please review when you have a minute?

mariapraetzellis commented 1 month ago

The changes all look good, thanks @briri