Closed briri closed 4 weeks ago
Sorry for the delay in getting a sample of what the related works JSON looks like to you.
Here is a recent DMP one of our pilot project partners uploaded through the phase 1 functionality. It has 8 related works that need review: https://api.dmphub.uc3prd.cdlib.net/dmps/10.48321/D13BEA529C
The related works can be found in the dmphub_modifications
array
@briri I've added the pull request now
@fraserclark I merged your PR and then needed to make a few minor adjustments to the way related_works were being checked/handled and also with the grant_id. I think maybe you had old data on your local or were working with some older registered plans that had some outdated metadata.
For reference, those changes are in my PR #594 no need for you to do anything with it, just an FYI
My notes from testing the slider:
Is it possible to add an "X" to close the slider window so you don’t have to scroll to the bottom in order to close the window?
I found one possible bug. I created a new plan via the upload feature but did not generate a DMP ID. Howver, there is still a DMP ID included in the slider. https://dmptool-stg.cdlib.org/dashboard/dmp/20240521-2394df1c2e33
@jupiter007 I just pushed the changes Maria request to my PR #594. Can you please review when you have a minute?
The changes all look good, thanks @briri
Add the final elements of the DMP Upload dashboard:
@fraserclark please make the PR to the
v5
branch when you're ready