CDLUC3 / dmptool

DMPTool version of the DMPRoadmap codebase
https://dmptool.org
MIT License
56 stars 13 forks source link

Bug/fix yarn build #603

Closed briri closed 1 week ago

briri commented 3 weeks ago

Fixes for 502 errors #605.

jupiter007 commented 3 weeks ago

The only comment I have is that I think the loaders for webpack typically go under "dependencies". But if it is working, then I guess it's not a problem.

briri commented 3 weeks ago

thanks, I think you may be right. Rails' use of webpack is weird, and we moved to something called js-bundling when we upgraded to Rails 6 a year ago, so I'm not entirely sure what the relationship between the 3 is.

I will move them back to dependencies if we see build errors or any visual errors in the the deployed code

briri commented 2 weeks ago

You were 💯 right @jupiter007. I moved those packages from devDependencies to normal dependencies. I also removed lingering references to the ERA loader in the web pack config.

This PR now also contains the few tweaks made to address the performance issues that were creating the 502 errors.

briri commented 1 week ago

am going to merge this one. It has been running now on the new AL2023 stage servers for several weeks. I am able to build the app and we haven't been receiving 502s.