CDLUC3 / dmptool

DMPTool version of the DMPRoadmap codebase
https://dmptool.org
MIT License
59 stars 13 forks source link

Bug/narrative pdf is not removed from upload plan #629

Closed jupiter007 closed 4 months ago

jupiter007 commented 4 months ago

Fixes # #563

Changes proposed in this PR:

Test Steps that I completed

  1. Click on "Upload Plan" and then the "Add Plan" button
  2. Enter Project Name and Upload a PDF
  3. Click "Save & Continue"
  4. Clicked "Yes, I have a funder" radio button and entered "NSF" as the Funder Name
  5. Clicked "Save & Continue"
  6. Entered "praetzellis" as Principal Investigator, and selected "EAGER: SMART-DMSP" and clicked "Save & Continue" and then "Save & Continue" again
  7. Clicked on "Project name & PDF upload"
  8. Checked the "Remove PDF" checkbox and clicked "Save & Continue"
  9. Went back into "Project name & Pdf upload", and noticed that the PDF no longer displayed
  10. I checked the database table, and noted that the narrative was removed from the metadata and that the PDF was no longer in the "active storage" tables.
  11. I uploaded a new PDF and clicked "Save & Continue"
  12. I then returned to "Project name & PDF upload" and saw that the new PDF was there.
github-actions[bot] commented 4 months ago
1 Error
:no_entry_sign:

Please include a CHANGELOG entry.

You can find it at [CHANGELOG.md](https://github.com/DMPRoadmap/roadmap/blob/main/CHANGELOG.md).

Generated by :no_entry_sign: Danger