CDLUC3 / dmptool

DMPTool version of the DMPRoadmap codebase
https://dmptool.org
MIT License
59 stars 13 forks source link

Upgrade to Rails 7.2 #661

Closed briri closed 1 week ago

briri commented 2 weeks ago

Fixes #657, #658 and #659

Changes proposed in this PR:

github-actions[bot] commented 2 weeks ago
1 Error
:no_entry_sign:

Please include a CHANGELOG entry.

You can find it at [CHANGELOG.md](https://github.com/DMPRoadmap/roadmap/blob/main/CHANGELOG.md).
1 Warning
:warning: This PR is too big! Consider breaking it down into smaller PRs.

Generated by :no_entry_sign: Danger

briri commented 2 weeks ago

Research Outputs page issues:

Finalize page not loading. Logs report an error on line 13 with undefined dmphub_api_base_url

Follow up page not saving funding changes. Error is:

[2bd0af44-bf90-4d47-84b7-1fef8c8651fd] NoMethodError (undefined method `each' for nil:NilClass):
[2bd0af44-bf90-4d47-84b7-1fef8c8651fd]   
[2bd0af44-bf90-4d47-84b7-1fef8c8651fd] app/controllers/dmptool/plans_controller.rb:46:in `follow_up_update'

React page not loading. It reports a 500 error

briri commented 1 week ago

fixed most of the issues above.

Now having trouble with the license selector on the research outputs page and comms with the dmphub. DMPHub returns a 401 when authenticating