Closed briri closed 1 week ago
1 Error | |
---|---|
:no_entry_sign: | Please include a CHANGELOG entry.
|
1 Warning | |
---|---|
:warning: | This PR is too big! Consider breaking it down into smaller PRs. |
Generated by :no_entry_sign: Danger
Research Outputs page issues:
Finalize page not loading. Logs report an error on line 13 with undefined dmphub_api_base_url
Follow up page not saving funding changes. Error is:
[2bd0af44-bf90-4d47-84b7-1fef8c8651fd] NoMethodError (undefined method `each' for nil:NilClass):
[2bd0af44-bf90-4d47-84b7-1fef8c8651fd]
[2bd0af44-bf90-4d47-84b7-1fef8c8651fd] app/controllers/dmptool/plans_controller.rb:46:in `follow_up_update'
React page not loading. It reports a 500 error
fixed most of the issues above.
Now having trouble with the license selector on the research outputs page and comms with the dmphub. DMPHub returns a 401 when authenticating
Fixes #657, #658 and #659
Changes proposed in this PR:
@import
and$
variable references in all SASS filesDMPRoadmap
toDmpRoadmap
rails app:update
script tp let Rails 7 build its own version of all thebin/*
files and theconfig/application.rb
,config/environments/*.rb
files and most initializersapp/assets/fonts
directoryapplication.js
enum [variableName] { variableOne: 0, variableTwo: 1 }
format to using a constant likeVARIABLE_NAME = %w[variableOne variableTwo]
coder
to be defined. So had to change all instances likeserialize :option_list, Array
so that they use named parameters likeserialize :option_list, type: Array, coder: JSON
super
within a method you no longer need to pass the method's input variables directlyRails.configuration.x.dmproadmap.[variableName]
to the shorterRails.configuration.x.[variableName]
that happened within theconfig/initializers/_dmproadmap.rb
was not happening. The AnywayConfig gem is still properly loading all variables, but the initializer file is now running before AnywayConfig so it was setting all variables to null or the default values defined inconfig/dmproadmap.yaml
. to correct this we needed to:config/initializers/_dmproadmap.rb
file since it is no longer usefulapplication.[variableName]
andorganization.[variableName]
toapplication_[variableName]
andorganization_[variableName]
config/dmproadmap.yaml
file so that it contains all of the default variables that were previously defined in theconfig/initializers/external_apis/*.rb
files.config/configs/dmproadmap_config.rb
so that it now contains all variables (there were some that were defined within the old initializers.max_pages = Rails.configuration.x.application.api_max_page_size
becamemax_pages = Rails.configuration.x.dmproadmap.application_api_max_page_size