CDLUC3 / dmptool_late_2019

Home of the DMP Roadmap-based version of the DMPTool
MIT License
24 stars 6 forks source link

Verify data for multi-select box answer format #205

Closed stephaniesimms closed 5 years ago

stephaniesimms commented 5 years ago

We removed multi-select box as an answer format in the roadmap code. https://github.com/DMPRoadmap/roadmap/issues/1771

All existing questions w/this format should become multiple choice format instead, which has the same functionality. Check that this worked for the templates that use it and that we have no data validation errors in dmptool. We have 16 templates that use the multi-select box but none of them appear to have any values defined. So unless they have the 'additional info' checkbox ticked then there's actually nowhere for the user to answer the question.

briri commented 5 years ago

Looks like any questions that were multi-select have been converted to text for backward compatibility.

screen shot 2018-12-12 at 1 57 45 pm

I don't b believe any of the multi-selects were used properly in the past. They all ask the user for one selection in the questions' language:

<p>6.6.a Estimate Percentage of Assets Under SD 609 Restrictions<br>In your estimation, what percentage of the digital assets in this DMP fall under SD609 restrictions?</p>

<p>Project Duration<br>Please provide the project duration [months]</p>

<p>Project Duration: Please enter the number of months over which the project work will be funded.</p>

It does not however look like the template itself is backward compatible. The old multi-select options are missing:

screen shot 2018-12-12 at 2 02 48 pm
stephaniesimms commented 5 years ago

what template is this in the screenshot @briri ? to my knowledge only GoMRI and USGS have such long/complex templates...

my feeling is that as long as none are new/published templates it doesn't matter too much how we handle the conversion. this looks fine to me to retain the multi-select text in the additional info field.

stephaniesimms commented 5 years ago

answer format converted to text looks good. closing.