CDLUC3 / dmptool_late_2019

Home of the DMP Roadmap-based version of the DMPTool
MIT License
24 stars 6 forks source link

Global plan status cleanup for plans created prior to v3 (esp to flag test plans) #238

Closed cpwillett closed 5 years ago

cpwillett commented 5 years ago

Janice Masud-Paul from Drexel writes:

We have plans that are more than a year old that are empty or obviously tests visible to the entire organization. I would like to make them private.

marisastrong commented 5 years ago

Seems like instead of private, they should be set as test plans.

briri commented 5 years ago

Agree with @marisastrong. Org admins don't have a way to change the visibility on behalf of their users. If you can get a cutoff date, we can look into doing a bulk update on the DB.

cpwillett commented 5 years ago

Is there a reason admin couldn't have the functionality to do it themselves?

briri commented 5 years ago

We'd have to figure out the best approach to let admins do it. We restrict what org admins can do due to GDRP privacy requirements (some installations won't even let admins view plans) so it could get very messy if we have a lot of flags to turn functionality on/off.

I'll defer to @stephaniesimms on deciding whether or not it warrants a feature enhancement. This seems like something that wouldn't be used very often.

briri commented 5 years ago

Also, do we know what the end goal for setting them to 'test' is? Is Janice just hoping to remove them from being counted in stats?

stephaniesimms commented 5 years ago

I agree that these should be set to test plans (or private...) and we can do a global cleanup for org and public plans. Cutoff date should be migration to the new version of the tool. Since then we haven't had issues with test plans in the public list because we implemented the 50% questions answered threshold to change the visibility to org or public.

Our terms of use and privacy policies state that plan owners have control over their plans. We provide admins with insight into plans created by users at their institutions for program dev purposes.

@briri we can figure out a global cleanup to switch status of plans created prior to 28Feb2018 with:

briri commented 5 years ago

sounds good @stephaniesimms I will plan to run this as part of the next deploy. Will collect the list or affected Organizations and Plan titles when I run it.

briri commented 5 years ago

The query has been run. I marked any plan with the word 'test' in the title that had not been updated since 2/1/18 as test.

Will post the list of affected records on slack

stephaniesimms commented 5 years ago

it's fine that test plans remain in the org admin plans table now that they're labeled appropriately. and the roadmap issues you just finished related to calculating usage stats should remedy any other associated problems.

can you also mark any blank plan (no questions answered) that has not been updated since 2/1/18 as 'test'? i think it's safe to assume that these are also test plans. this should go a long way in cleaning up stats and addressing the original issue of decluttering org plans lists.

briri commented 5 years ago

done. updated any plan that had no questions answered and had not been updated since the migration 2/1/18

stephaniesimms commented 5 years ago

reviewed csv and test plan status changes look good. closing.