CDLUC3 / dmptool_late_2019

Home of the DMP Roadmap-based version of the DMPTool
MIT License
24 stars 6 forks source link

Incorrect default guidance & guidance selections #78

Closed stephaniesimms closed 6 years ago

stephaniesimms commented 6 years ago

I tested various combinations of creating a plan and always get the wrong default template (DMP Template from DCC - screenshot below). In addition, I get a weird assortment of guidance options with the wrong default guidance (Digital Curation Centre - screenshot below) and the default guidance is not selected.

Correct default template is called "Digital Curation Centre" (the wrong templates are displayed in the public Funder Requirements list too). Correct default guidance is called "DMPTool." Desired behavior is to provide the correct template and correct guidance auto-selected. The guidance list should have the following options only (auto-selected):

screen shot 2018-02-19 at 11 37 33 am

briri commented 6 years ago

I just synced up the dmptool-stg database with what you have in dmp2-stg (where we fixed the default template issue). Please give it another try

stephaniesimms commented 6 years ago

@briri - thanks, now I get the correct default template when I create a plan and on the Funder Requirements page. template issue is resolved.

I still don't get the correct default guidance, however. and still have the weird assortment of options in the screenshot above.

briri commented 6 years ago

auto select default org's guidance, and selected research org's guidance

only show default org's guidance, and selected research org's guidance and my org's guidance on priority section

investigate displaying UCOP (default Org) as "DMPTool" in guidance selection list

stephaniesimms commented 6 years ago

the problem with the weird selections is that they aren't actually Guidance created by an Org. the selections coming up in the DMPTool are Funder/Org guidance attached to the Funder/Org templates. so the content is really long and not appropriate as guidance for other templates. the desired/correct behavior is not to include DOT, USGS, NOAA, WHOI in guidance selections at all.

"DMPTool" label is working now. But when I navigate to the Write plan page the tab says "Digital Curation Centre." It should say "DMPTool" and contain the DMPTool/UCOP guidance (screenshot).

another issue that i'll create separately but note here is that the tab behavior is newly weird. now the third tab in the screenshot below is pushed over in the second row. also sometimes guidance still stacks in a single tab, but if i click the tab it arranges itself in the proper tabs.

screen shot 2018-02-24 at 2 22 08 pm
stephaniesimms commented 6 years ago

it sounds like this can be resolved by the steps we discussed: 1) delete guidance groups for these funder/orgs. this guidance should be attached to templates as annotations and was mistakenly migrated as guidance. 2) make DMPTool/UCOP guidance the default. DCC guidance should be a duplicate but i need to verify. i know DMPTool guidance is correct and that's the label we want to use.

stephaniesimms commented 6 years ago

after latest testing on dmptool-stg, the weird Org options are cleared up. The default guidance behavior is still strange (screenshot below).

I see two options: UCOP and DMPTool and UCOP is checked. Ideally there should just be one called DMPTool that is checked. When I go to write the plan, I get the "DCC" guidance instead of DMPTool. If necessary you can replace the DCC guidance group with the DMPTool guidance group if that alleviates the default guidance issues. Or make UCOP/DMPTool the default.

screen shot 2018-02-25 at 3 54 46 pm

briri commented 6 years ago

what server were you on when you tested this? I believe I only made my changes on stage.

stephaniesimms commented 6 years ago

i'm testing on stage. and it did this during the webinar just now.

stephaniesimms commented 6 years ago

hallelujah it's working as expected now. Org short names appear in tabs and everything. UCAR template and guidance data are also fixed. closing issue!