search

CDLUC3 / dmsp_api_prototype

The new DMPTool API (formerly the DMPHub)
MIT License
0 stars 0 forks source link

Refactored test/citation-test script #6

Closed briri closed 3 months ago

briri commented 3 months ago

Hey @jupiter007 your script looked good. I refactored it a bit.

The primary changes were to add the dmproadmap_related_identifiers array to the initial query and then only do a full fetch of the DMP record if we need to update it.

I ran against the dev DB and all looks good. When you're back, we can run against stage

jupiter007 commented 3 months ago

Thanks Brian.

jupiter007 commented 3 months ago

Hi @briri. Per your suggestion, I ran your script for stage, and there were only three DMPs that appeared to be missing citations. I checked DynamoDB, and it appears to have inserted the missing citations for the following: DMP#doi.org/10.48321/D132DC0f6f DMP#doi.org/10.48321/D17P5X DMP#doi.org/10.48321/D14A42200F

When I ran it a second time, there were no more identified, indicating that the script fixed the issue for Stage.

briri commented 3 months ago

Excellent! I will go ahead an merge then.

briri commented 3 months ago

Do you want to do a PR to main and run the script in prd?

jupiter007 commented 3 months ago

Do you want to do a PR to main and run the script in prd?

Thanks Brian. Yes, I will go ahead and create a PR and run it against production.