search

CDLUC3 / dmsp_aws_prototype

Sceptre CloudFormation templates for DMPHub v2
MIT License
1 stars 0 forks source link

Feature landing page optimize code #102

Closed jupiter007 closed 3 months ago

jupiter007 commented 4 months ago

I updated landing.js to not use the getValue() function to set the property values, since getValue() is a recursive function, and I was concerned that it was slowing the page load down. However, when I tested locally using Lighthouse, the performance didn't appear to change. But I still think it's good to get away from the recursive function if we can just use optional chaining.

I also added an abort controller to the useEffect so that we can make sure to cancel requests on unmount.

I also switched to using BrowserRouter in App.js and added some missing keys in the jsx.

briri commented 4 months ago

Let's get this deployed to the AWS development environment early next week when you have access to our AWS environment.

jupiter007 commented 4 months ago

@briri , I'm assuming I wait to merge this PR. Looks like there are merge blockers.