search

CDLUC3 / dmsp_aws_prototype

Sceptre CloudFormation templates for DMPHub v2
MIT License
1 stars 0 forks source link

Update Award APIs to prevent spamming devs #110

Closed briri closed 1 month ago

briri commented 8 months ago

The awards APIs are sending out error notifications to the admin account when they really shouldn't. For example: You must specify an award id (e.g. project=2223141) OR at least one of the following:\n a comma separate list of PI names (e.g \"pi_names=Jane Doe,Van Buren,John Smith\"), /\n title keywords (e.g. keyword=genetic+mRna), /\n a comma separated list of award years (optional) (e.g. years=2023,2021) is a legitimate error that gets sent back to the UI. The admin does not need to be notified!

Also update the admin email addresses to include Juliet

briri commented 3 months ago

Picking this one up because it is a simple fix and I got about 100 emails today. Someone appears to be doing some testing or something and using demo.datavers.org DOIs which return a 404 when the uc3-dmp-citation gem tries to fetch the BibTex citation metadata.

I added some error handling to just log a warning instead of a fatal error when this happens.