CDLUC3 / dmsp_aws_prototype

Sceptre CloudFormation templates for DMPHub v2
MIT License
1 stars 0 forks source link

Fix issue with NSF API #120

Closed briri closed 3 months ago

briri commented 3 months ago

Here is the query we run if the user provides an NSF award number: https://www.research.gov/awardapi-service/v1/awards/2332353.json

Here is the query we run when the user provides info in the other fields (title, PIs, year): https://www.research.gov/awardapi-service/v1/awards.json?pdPIName=praetzellis&dateStart=01%2F01%2F2023&dateEnd=12%2F31%2F2023&printFields=id,pdPIName,piEmail,title,awardee,ueiNumber,startDate,expDate,abstractText,fundsObligatedAmt

Note that the first does not include the printFields parameter and so it doesn't return the contact info or the abstract. This PR adds that parameter to the first scenario so that we get the same results back

@jupiter007 can you check the logic in the React page to make sure that if no contributor information is returned that it will not create an empty contributor record? I think that is why Maria was seeing an entry that just had a role of 'other' and nothing else.