search

CDLUC3 / dmsp_backend_prototype

The GraphQL (Apollo server) backend for the new DMSP system
0 stars 0 forks source link

Feature/combined auth #34

Closed briri closed 5 days ago

briri commented 4 weeks ago

@jupiter007 I am not 100% done with this yet, but I wanted to put the code changes out here to get your feedback. There is still some cleanup and a lot of testing to do.

I have not tested any of it. I finally got all of the Typescript issues resolved and wrapped my head around the @node/express-oauth-server documentation. I am sure there will be some issues that I need to iron out.

Both the JWT auth you setup and the OAuth2 access token use the same generateToken function. I am hoping that this will be enough to allow the GraphQL endpoints to work with a single token and not care where the auth came from.

I plan to test it out on Monday and start writing some Jest tests

jupiter007 commented 3 weeks ago

Hi @briri. I added a few comments to your PR. There's a lot for my brain to process, but I think it's looking good so far.

I noticed that you took the "feature/simple-authentication" branch to work off of, but I thought I merged that branch into development. I think you should make sure to merge the latest development branch into this one to make sure you have all the changes I made to fix the pipeline after my merge.

jupiter007 commented 6 days ago

Nice linting and tests