CDLUC3 / dmsp_frontend_prototype

Repo to test out new NextJS framework
MIT License
0 stars 0 forks source link

Tabs component for template templates #108

Closed fraserclark closed 1 month ago

fraserclark commented 2 months ago

We talked a bit about on the call yesterday if these "tabs" on the "Edit question" and "Edit Section" within the template builder are "real tabs" or just navigational elements to pages

template/{id}/q/{quid}/options template/{id}/q/{quid}/logic

Image

Image

I think I lean towards just making them "real tabs", there isn't much in the tabs either and they are conceptually editing the same thing.

There 2 big advantages of it being "pages" rather than tabs

We can "work around" these 2 big advantages to some extent

Let me know your thoughts

fraserclark commented 1 month ago

As a part of the style guide, I have styled these in the PR - it is real tabs as agreed above, so completely dynamic etc no page changes etc

https://github.com/CDLUC3/dmsp_frontend_prototype/pull/120

Basic style guide version could be used for anything Image

A more realistic example of it being used Image

jupiter007 commented 1 month ago

Hi @fraserclark , I just wanted to confirm that this ticket has been completed.