search

CDLUC3 / dmsp_frontend_prototype

Repo to test out new NextJS framework
MIT License
0 stars 0 forks source link

Create a "sizing" guide #149

Open fraserclark opened 1 month ago

fraserclark commented 1 month ago

We need to have some standardization on spacing. Update css and styleguide with it.

fraserclark commented 1 month ago

https://www.loom.com/share/48d32f8d21ca4c4e9ebb26e3ce84f81d

@andrewebdev @jupiter007 Video of work in progress - I ran out of time this afternoon to finish this off and create a proper PR. Hopefully it sorted by tomorrow morning.

Feel free to pull down the brand and have a snoop about with work so far. https://github.com/CDLUC3/dmsp_frontend_prototype/tree/feature/styleguide-spacing

jupiter007 commented 1 month ago

@fraserclark, that's awesome. Thanks so much for doing that work.

jupiter007 commented 1 month ago

@fraserclark , just one comment. I think we'll need an "xsmall" to $font-sizes in "globals.scss" so that we can use that size for microtext or errors below form fields.

fraserclark commented 1 month ago

Added xsmall in which is 0.75rem (12px)

It might be worth checking accessibility on this, I have a feeling the upcoming standard (still in draft) W3C Accessibility Guidelines (WCAG) 3.0 has preliminary recommendations for font sizes - although its probably far away from being approved and AAA does not have any standards on it I don't think