search

CDLUC3 / dmsp_frontend_prototype

Repo to test out new NextJS framework
MIT License
0 stars 0 forks source link

Added landing page from dmsp_aws_prototype to app and dockerized the app #24

Closed jupiter007 closed 3 months ago

jupiter007 commented 3 months ago

I wanted to see if I could incorporate the landing page from dmsp_aws_prototype to the app, and use Apollo GraphQL client to make calls to the Apollo Server.

Additionally, I dockerized the app for dev and prod.

jupiter007 commented 3 months ago

Looks great @jupiter007! I requested on small change to the image you're pulling for your Dockerfiles.

What is the difference between .ts and .tsx? Is it just that .tsx includes HTML?

Thank you for looking at my PR @briri. The ".tsx" is equivalent to using ".jsx", which is used to indicate that we are using JSX in the component. ".ts" would be used like we would use ".js", which would be just pure javascript, but with type annotations.

jupiter007 commented 3 months ago

Hi @briri, I made the updates you requested. Please take another look when you get the chance and let me know if it looks ok. Thanks.