Feature/graphql file structure

CDLUC3 / dmsp_frontend_prototype

Repo to test out new NextJS framework

MIT License

0 stars 0 forks source link

Feature/graphql file structure #36

Closed jupiter007 closed 2 months ago

jupiter007 commented 2 months ago

I did some tests and made some updates per ticket #28.

Added some preliminary folder structure for graphql files and placed them under lib/graphql. This includes the client instance for graphql requests in Server Components, client.ts, client instance for Client components, apollo-client.ts, the apollo-wrapper.ts file used for the Apollo Provider to allow for GraphQL hookes in Client components, and mutations, queries, and methods to achieve those.
I updated the main layout.tsx wrapper to include a placeholder Header and Footer
I updated the root page.tsx to include placeholder data of collaborator roles which is done on the server side.
I added some new packages, most importantly @apollo/experimental-nextjs-app-support
I added a CHANGELOG.md file. I would like to keep records of changes there
I removed references to tailwind

briri commented 2 months ago

Not much I can say here. All looks okay to me. Something I did notive, which is a bit nit-picky I confess, is that in some places the indentation looks like 2 spaces, where in others it's four.

We should probably use "editorconfig" so that our editors match with the preferred coding style. (Though I admit this is low priority really, just a suggestion)

➕ for using editorconfig. It will be helpful

jupiter007 commented 2 months ago

Not much I can say here. All looks okay to me. Something I did notive, which is a bit nit-picky I confess, is that in some places the indentation looks like 2 spaces, where in others it's four.

We should probably use "editorconfig" so that our editors match with the preferred coding style. (Though I admit this is low priority really, just a suggestion)

Thanks for bringing that up @andrewebdev. I totally agree. I think it's a good idea to use .editorconfig to set some standard configs. I will create a ticket for that. I have some extensions in VSCode that is probably contributing to the inconsistencies.

jupiter007 commented 2 months ago

@andrewebdev I created this ticket to address adding an .editorconfig file for formatting:https://github.com/CDLUC3/dmsp_frontend_prototype/issues/37

jupiter007 commented 2 months ago

I'm going to merge this PR since I believe I addressed the comments.