search

CDLUC3 / mrt-doc

Documentation and Information regarding the Merritt repository
8 stars 4 forks source link

UI: Handling of `port` var in Capistrano - looks like a typo in config/puma.rb #577

Closed ashleygould closed 3 years ago

ashleygould commented 3 years ago

This is clearly wrong, but does not seem to cause any issues. 

  uc3adm@uc3-uc3ops01x2-dev:~/tools/deploy/mrt-dashboard/config$ grep port puma.rb
  # Specifies the `port` that Puma will listen on to receive requests; default is 3000.
  port        ENV.fetch('PORT', 26_181)

I think we should review how we are configuring port var. Perhaps it should be set as ENV with default as are other config options in config/deploy.rb

terrywbrady commented 3 years ago

I do not understand what change is being requested. Is the issue with the port? Note the following: 

bash-4.2$ rubocop
Inspecting 175 files
..............................................................................................C................................................................................

Offenses:

config/puma.rb:12:31: C: Style/NumericLiterals: Use underscores(_) as thousands separator and separate every 3 digits with them.
port        ENV.fetch('PORT', 26181)
                              ^^^^^

175 files inspected, 1 offense detected, 1 offense auto-correctable
terrywbrady commented 3 years ago

@ashleygould , can I close this issue?