search

CDRH / african_poetics

Orchid / Rails site for Contemporary African Poets part of African Poetics site
0 stars 0 forks source link

Update Orchid #52

Open techgique opened 4 years ago

techgique commented 4 years ago

Use the latest release and review templates copied from it in the past for customization to include upstream changes

karindalziel commented 3 years ago

Still needs a patch update but update to 3 is done

BorsaMetin commented 3 years ago

Hello World!

I love Orchid!

jduss4 commented 3 years ago

I updated to 3.1.1 and made small changes for functionality, but I haven't gone through an indepth review of the various changes to templates yet.

techgique commented 1 year ago

I noticed that this change in Orchid hasn't been incorporated: https://github.com/CDRH/orchid/blob/dev/app/views/items/_search_res_items.html.erb#L1 in the override here: https://github.com/CDRH/african_poetics/blob/main/app/views/items/_search_res_items.html.erb

This makes me think we should probably note all template changes in Orchid in our changelog notes between versions to greatly simplify incorporating said changes in overrides elsewhere. It'll be more documentation on the Orchid side, but much easier for updating overrides in other Rails apps.

Things like this are also why we try to target overrides as narrowly as possible. Sometimes it becomes apparent we need to break down some of these templates into more partials. Might be the case we'll want to do that for the individual item type displays in search results here in the future :+1: