CDRH / api

Codenamed "Apium": An API to access all public Center for Digital Research in the Humanities resources
https://cdrhdev1.unl.edu/api_frontend
MIT License
3 stars 1 forks source link

Rspec linter #119

Open jduss4 opened 3 years ago

jduss4 commented 3 years ago

NOTE: this PR goes into the rspec branch because I didn't want to lint the old tests, although it wouldn't be hard to switch things out whichever way you decide

I decided to throw in a linter (https://github.com/testdouble/standard). You can run it with bundle exec standardrb. I split up the commits into two: 1 stuff that's straightforward, 2 things that need a little bit of eyeball

It has a few opinions I don't necessarily like, but I think it's probably configurable if we want to mess with that, or just live with its decisions. Or you can just close this PR and forget about it.

The cool news is that if you do like the linter, then I can set up a githook to run it before commits and also a github action to run it automatically when someone opens a PR.