CDRH / api

Codenamed "Apium": An API to access all public Center for Digital Research in the Humanities resources
https://cdrhdev1.unl.edu/api_frontend
MIT License
3 stars 1 forks source link

version API and deploy at v1 url #58

Closed jduss4 closed 6 years ago

jduss4 commented 6 years ago

Do we want the URL to only have major releases? That makes sense to me, since it would presumably not be altering backwards compatibility

Probably do not need to change the app itself very much, except perhaps to report the version in each set of JSON results?

jduss4 commented 6 years ago

After deployed, set version using this advice:

https://stackoverflow.com/questions/9073446/where-do-you-store-your-rails-applications-version-number/9086325#9086325

jduss4 commented 6 years ago

VHOST

techgique commented 6 years ago

App is up and running at https://cdrhapi.unl.edu/v1

I think this line already handles setting our app-wide VERSION constant: https://github.com/CDRH/api/blob/master/config/initializers/config.rb#L5

What does your the "VHOST" comment mean?

If we think we're ready with changes in this repo, submit a PR that changes VERSION to 1.0.0?

jduss4 commented 6 years ago

I suspect that VHOST got typed in the wrong window!

jduss4 commented 6 years ago

@techgique that link is not working for me, unfortunately. I get a 404 when I visit it

techgique commented 6 years ago

Links fixed. Will populate the API next

techgique commented 6 years ago

Online here: https://cdrhapi.unl.edu/v1

jduss4 commented 6 years ago

Opening a new issue to address an API release