search

CDRH / bandhistory_rails

Band history website redone with Rails and Orchid
0 stars 0 forks source link

Fixes for search results #19

Closed karindalziel closed 4 years ago

karindalziel commented 4 years ago

I finished designing the search results (see #1 ) but a couple of things still need fixing

1: links don't work. kinda a big deal

2: I grabbed a helper from family letters but I assume much of this code is unnecessary https://github.com/CDRH/bandhistory_rails/blob/ef38556c502ec6a35e1547545f1341a010f84cb4/app/helpers/items_helper.rb#L27

jduss4 commented 4 years ago

agreed, I don't believe title_label is being used for the band site. The trick was that our title link helper was using link_to and passing the results to another link_to which used classes and a block. For now I just removed the link_to part from the band history project's helper, but longterm with Orchid we may want to think about how that interacts with the search results, and if it should accept a block, etc.