search

CDRH / chesnutt

Rails site code for the Charles W. Chesnutt Archive https://chesnuttarchive.org
0 stars 0 forks source link

Fix authors of certain reviews #117

Closed kmcmullen closed 3 years ago

kmcmullen commented 3 years ago

It seems that we added "Anonymous" as the author of reviews that actually had a known author; I need to go back and add those names in there. The correct author is still being pulled into the API (seemingly), but it's just not displaying in the source citation. Thus, I think I can use the list of creators to find the ones that need changing: https://cdrhdev1.unl.edu/chesnutt/browse/creator.name

kmcmullen commented 3 years ago

May not be as wide-spread as I first though; investigate.

karindalziel commented 3 years ago

@kmcmullen sorry this was my fault - a bunch of files had no author at all, to fix the indexing I added Anonymous to all

I believe they were all files in the early numbers of the reviews - probably the first 20 or 30

karindalziel commented 3 years ago

@kmcmullen here's the files I changed https://github.com/CDRH/data_chesnutt/commit/cf59fa0d405320b856f7fc990e3887c0122c0634?branch=cf59fa0d405320b856f7fc990e3887c0122c0634&diff=unified

kmcmullen commented 3 years ago

Yep, no worries. They were all ones that were incorrectly encoded to begin with and then incorrectly proofed, so that was the real problem. It's an easy fix.

On Fri, Jul 30, 2021 at 11:30 AM Karin Dalziel @.***> wrote:

@kmcmullen https://github.com/kmcmullen sorry this was my fault - a bunch of files had no author at all, to fix the indexing I added Anonymous to all

I believe they were all files in the early numbers of the reviews - probably the first 20 or 30

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CDRH/chesnutt/issues/117#issuecomment-890006703, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSKAZ6SWWH55QZTIWXRLUTT2LHSLANCNFSM5BHJ2MLQ .

kmcmullen commented 3 years ago

Thanks for that list of files, Karin. Very helpful. I've used it to fix all of those. Closing.