search

CDRH / chesnutt

Rails site code for the Charles W. Chesnutt Archive https://chesnuttarchive.org
0 stars 0 forks source link

Add language for classcode/editorial note #205

Closed karindalziel closed 1 year ago

karindalziel commented 1 year ago

I have added the classcode to the bottom metadata, but it needs wording

Screen Shot 2022-12-13 at 3 21 30 PM

You can change the "editorial notes" wording here: https://github.com/CDRH/chesnutt/blob/design/app/views/items/_show_bottom_metadata.html.erb#L35

and the explanation here: https://github.com/CDRH/chesnutt/blob/design/config/locales/en.yml#L293

kmcmullen commented 1 year ago

I ended up sticking it in the "show_bottom_metadata" file so that I could include italic text (but maybe there's a way to do that from locales...?). In any case, I can't think of when we'd need to use that language elsewhere, so I think it's fine.

kmcmullen commented 1 year ago

Also, in an ideal world it would be nice to have an embedded list within this bottom metadata list, with each of these values on a separate line (it would just make it easier to read). I tried adding an <ul> within this particular <li> but it didn't format correctly (each embedded<li> just showed up in the same hierarchy as the rest of the items).

karindalziel commented 1 year ago

Screen Shot 2022-12-14 at 3 13 16 PM

kmcmullen commented 1 year ago

I think this looks great (I deleted the citation at the end; the directors said it wasn't necessary, because these are terms no only confined to this book—which I didn't know). I've made an issue (#214 ) to have a larger discussion about these codes later, but that can wait until after the launch. Until then, I don't think there's any reason to have Laura (or anybody) do a find-and-replace, as we discussed.

I'm gonna say this is done for now and close this issue.