Remove extra space around additions and deletions

CDRH / chesnutt

Rails site code for the Charles W. Chesnutt Archive https://chesnuttarchive.org

0 stars 0 forks source link

Remove extra space around additions and deletions #251

Closed kmcmullen closed 2 days ago

kmcmullen commented 3 months ago

There is an extra space being inserted before and after <add>s and <del>s. We had this problem with the galley proofs (manuscripts) and the problem was fixed, but it doesn't seem to be working in correspondence. See the first sentence of the letter here, for example: https://cdrhdev1.unl.edu/chesnutt/item/ccda.corr01513.

erinchambers commented 3 days ago

Aha - we were adding spaces through the tei.scss stylesheet! For example:

.tei_add_place_above {
  &:before {
    content: " [above line] ";
    text-decoration: none;
  }
}

All our .tei_add_* styles have spaces before and after the [*] verbiage, including things like " [top margin] " and " [bottom margin] ", etc. @kmcmullen Should I remove the spaces from all of them?

kmcmullen commented 2 days ago

Hey @erinchambers! I see. No, I think it could create problems to remove it everywhere, and I see why we want it to be inserted, for legibility, in lots of places. So let's just leave it as-is. I'll close this issue. Thanks for looking into that! Sorry for the hassle!