search

CDRH / chesnutt

Rails site code for the Charles W. Chesnutt Archive https://chesnuttarchive.org
0 stars 0 forks source link

Border around some thumbnails? #44

Closed kmcmullen closed 3 years ago

kmcmullen commented 3 years ago

A grey border seemingly begins appearing around the edge of thumbnail images partway through ccda.proof00001.xml. The first one that I noticed appears on page 173 of the book (search for "christening dinner at Major" and you'll see it). I haven't noticed if this is an issue in other files, but haven't looked too closely.

karindalziel commented 3 years ago

It is happening when an image is in a paragraph and goes away when indent is removed.

Will come back to this a bit later because I can't find an obvious easy solution - nothing I do in the spans within the P seems to make a difference.

kmcmullen commented 3 years ago

I hadn't noticed that pattern, but yes, it appears that the border only appears when the image is within a paragraph. (Page 185 here has no border, but page 189 does, for example: here: https://cdrhdev1.unl.edu/chesnutt/item/ccda.proof00002)

On Mon, Jun 14, 2021 at 4:27 PM Karin Dalziel @.***> wrote:

It is happening when an image is in a paragraph and goes away when indent is removed.

Will come back to this a bit later because I can't find an obvious easy solution - nothing I do in the spans within the P seems to make a difference.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CDRH/chesnutt/issues/44#issuecomment-861008013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSKAZZO4KGZTTT6MUPVWWDTSZX43ANCNFSM4Y2ALD2A .

--

Kevin McMullen Research Assistant Professor, Department of English Fellow, Center for Digital Research in the Humanities Project Manager and Associate Editor, Walt Whitman Archive https://whitmanarchive.org/ Editor, Fanny Fern in The New York Ledger http://fannyfern.org/ Project Manager, Charles Chesnutt Digital Archive https://chesnuttarchive.org/ President, Digital Americanists https://digitalamericanists.org/ University of Nebraska-Lincoln 336D Andrews Hall Lincoln, NE 68588-0333 @.***

karindalziel commented 3 years ago

ah! figured it out. this works but for the life of me can't figure out why

span.pageimage {

  text-indent: 0;
}
karindalziel commented 3 years ago

I guess the text indent was inherited? I hope that doesn't show up elsewhere dun dun dunnnnn

kmcmullen commented 3 years ago

Did a spot-check and this seems to have taken care of the problem. Closing issue.