search

CDRH / chesnutt

Rails site code for the Charles W. Chesnutt Archive https://chesnuttarchive.org
0 stars 0 forks source link

Extra space inserted in galley proof display #7

Closed kmcmullen closed 3 years ago

kmcmullen commented 3 years ago

There are spaces being inserted between elements in the display of the Chesnutt galley proofs. We initially thought it was an encoding problem (with erroneous spaces being inserted in the encoding), but Kevin has checked a number of instances and that doesn't seem to be the case. The stylesheet must be inserting a space for some reason. See the example of "vice-like grip" on page 1 here: https://cdrhdev1.unl.edu/chesnutt/item/ccda.proof00001 (search for "ice-like"). You can also see it in several instances at the top of page "B" here: https://cdrhdev1.unl.edu/chesnutt/item/ccda.proof00003 (search for "Took part in Rhode Island").

karindalziel commented 3 years ago

@kmcmullen This is fixed in proof00003 (just had to make a slight adjustment: https://github.com/CDRH/data_chesnutt/commit/d91a746cdbe2b29f37ace39382fea57909c75db2)

I could not rerun proof00001, see issue #11 for details

Note that in the past when I have done this, sometimes we then find places where people wanted spaces but they are not there anymore, because the indented code added them. we'll have to fix these if we see them by adding spaces in the tei

kmcmullen commented 3 years ago

I think this is taken care of. Closing.