search

CDRH / chesnutt

Rails site code for the Charles W. Chesnutt Archive https://chesnuttarchive.org
0 stars 0 forks source link

display for block quotes #82

Closed kmcmullen closed 3 years ago

kmcmullen commented 3 years ago

We need a way to render block quotations, ideally indented and in a smaller font. They are encoded in <floatingText>/<body> and within that either in <p> or <lg>. I think you should just be able to match on <floatingText>, and style everything within it to appear indented and in smaller font. There's an example at the beginning of this story: https://cdrhdev1.unl.edu/chesnutt/item/ccda.works00081. There's also a number of examples in https://cdrhdev1.unl.edu/chesnutt/item/ccda.works00069

karindalziel commented 3 years ago

Just curious, but is there a reason you are not using the "quote" tei tag for these? I can certainly style them the same, I was just wondering.

(that first example DOES use <quote> but the second does not)

kmcmullen commented 3 years ago

Hmmm. Good question. I guess because we've just always used floating text for such things in Whitman. In reading the definition of <quote>, I guess it does make sense (at least in that first example). But I could envision instances in which wouldn't work, and which we'd need floatingText. Can we just style both the same way?

karindalziel commented 3 years ago

@kmcmullen Can you look at these examples and tell me if this is what you want the quotes to look like?

Screen Shot 2021-07-13 at 1 13 31 PM

Screen Shot 2021-07-13 at 1 13 18 PM

karindalziel commented 3 years ago

this one, rev00137 is a little weird. it uses the <quote> tag, and since a <p> is required inside a blockquote tag, the text is indented. should I add a rule so paras in a blockquote should not indent?

Screen Shot 2021-07-13 at 1 16 40 PM

karindalziel commented 3 years ago

one more example, from proof00003

Screen Shot 2021-07-13 at 1 29 47 PM

kmcmullen commented 3 years ago

@kmcmullen Can you look at these examples and tell me if this is what you want the quotes to look like?

Screen Shot 2021-07-13 at 1 13 31 PM

Screen Shot 2021-07-13 at 1 13 18 PM

These both look great to me!

kmcmullen commented 3 years ago

one more example, from proof00003

Screen Shot 2021-07-13 at 1 29 47 PM

This one looks good too.

kmcmullen commented 3 years ago

this one, rev00137 is a little weird. it uses the <quote> tag, and since a <p> is required inside a blockquote tag, the text is indented. should I add a rule so paras in a blockquote should not indent?

Screen Shot 2021-07-13 at 1 16 40 PM

The quote tag is wrong here; I'll just change it to the proper encoding, so you can disregard this example (unless it seems to be wide-spread...?)

kmcmullen commented 3 years ago

this one, rev00137 is a little weird. it uses the <quote> tag, and since a <p> is required inside a blockquote tag, the text is indented. should I add a rule so paras in a blockquote should not indent? Screen Shot 2021-07-13 at 1 16 40 PM

The quote tag is wrong here; I'll just change it to the proper encoding, so you can disregard this example (unless it seems to be wide-spread...?)

Update: I fixed the encoding, but it seems like the spacing before the quote is much less than the spacing after the quote. Any way to fix that? If not, not a big deal. https://cdrhdev1.unl.edu/chesnutt/item/ccda.rev00137

Screen Shot 2021-07-13 at 2 24 14 PM

Otherwise, these all seem good to go.

karindalziel commented 3 years ago

ok! I will add the spacing issue as an "after launch" issue

kmcmullen commented 3 years ago

Yep. Seems fine.

On Tue, Jul 13, 2021 at 4:05 PM Karin Dalziel @.***> wrote:

ok! I will add the spacing issue as an "after launch" issue

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CDRH/chesnutt/issues/82#issuecomment-879402326, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSKAZ4C7EWOAR4NYYR2TUDTXSTC5ANCNFSM47EP6LCQ .