search

CDRH / chesnutt

Rails site code for the Charles W. Chesnutt Archive https://chesnuttarchive.org
0 stars 0 forks source link

pubPlace issue in metadata #88

Closed kmcmullen closed 3 years ago

kmcmullen commented 3 years ago

There's a problem with the "publisher_build" variable. For books, we wanted it to stick the pubPlace and publisher together, but it's doing the same thing for periodicals too. Some of the periodicals don't have pubPlace, in which case, it's no problem. But for the ones that do have a pubPlace, it's getting pulled in and italicized along with the name of the periodical. See here: https://cdrhdev1.unl.edu/chesnutt/item/ccda.works00045.

The same goes for <publisher>, which is also getting pulled in for periodicals, when it shouldn't (this is the case for pretty much all of the reviews: see here: https://cdrhdev1.unl.edu/chesnutt/item/ccda.rev00031). For these, we just want the title of the newspaper in the citation. So this last example should be: Anonymous, "[Review of The Conjure Woman]," The Sunday Times-Union and Citizen (September 10, 1899): 4.

Can't quite figure out how to fix this.

kmcmullen commented 3 years ago

This is the issue that I was discussing with you today (the remaining citation issue, where pubPlace and publisher are getting pulled in incorrectly). Seems I had already created an issue for it. This mainly seems to be an issue in "Reviews" but also comes up a few other places I think.

karindalziel commented 3 years ago

@kmcmullen so to be clear, would my rules would look something like this?

kmcmullen commented 3 years ago

Nope. The "if book" part is correct. But for "if not book," we just want to use (which is the name of the periodical that the work appeared in).</p> <p>On Tue, Jul 27, 2021 at 3:51 PM Karin Dalziel <strong><em>@</em></strong>.***> wrote:</p> <blockquote> <p>@kmcmullen <a href="https://github.com/kmcmullen">https://github.com/kmcmullen</a> so to be clear, would my rules would look something like this?</p> <ul> <li>if book <ul> <li>-> use pub place and publisher name</li> </ul></li> <li>if not book <ul> <li>-> use publisher name only</li> </ul></li> </ul> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <a href="https://github.com/CDRH/chesnutt/issues/88#issuecomment-887826069">https://github.com/CDRH/chesnutt/issues/88#issuecomment-887826069</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/ADSKAZ6G5HV5MCFKZ57XCHDTZ4L5XANCNFSM47OVJUAQ">https://github.com/notifications/unsubscribe-auth/ADSKAZ6G5HV5MCFKZ57XCHDTZ4L5XANCNFSM47OVJUAQ</a> .</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/kmcmullen"><img src="https://avatars.githubusercontent.com/u/14983271?v=4" />kmcmullen</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>I did a pretty thorough spot-check (if there is such a thing as a thorough spot-check), and didn't notice any problems. I think we're good! Closing.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>