search

CDRH / earlywashingtondc

OSCYS Rails site
http://earlywashingtondc.org
2 stars 0 forks source link

Internal Links from <blbl> Tag #124

Closed kacinash closed 5 years ago

kacinash commented 9 years ago

When a case is cited within a document, and it is a case that we have in the project, can we create an internal link to the Case Page by adding the caseID to the bibl tag like so?

<bibl type="case" xml:id="oscys.caseid.0011">Queen v. Hepburn</bibl>

karindalziel commented 9 years ago

Yes, if you add the tag and commit the XML (and let me know the name of a file you've added it to), I'll make it link. I don't _think_ it will be a problem.

karindalziel commented 9 years ago

I am adding this as a v2 issue, though, because I want to make sure other things are finished first. I'll probably be able to get to it this round anyway.

kacinash commented 9 years ago

@karindalziel: I added xml:ids where needed in oscys.report.0005.001 & oscys.report.0006.002 and committed the files.

I also used corresp where the case citations are repeated. If this is a problem, I will just take out the id for that citation, and it will only be linked once in the document.

kacinash commented 9 years ago

This is a note for myself: After this has been accomplished, I will need to go through all the documents and insert xml:ids where necessary.

karindalziel commented 7 years ago

@kacinash is this done? I'm not sure where to look

kacinash commented 7 years ago

@karindalziel No, it is not done. Documents have been encoded with xml:id in bibl tags, like this one. We need them to link to the cases.

karindalziel commented 7 years ago

OK, thinking through the rules for this: 

<bibl type="case">
5 Hen. &amp; Munfd. 542 6.
<unclear reason="illegible">Samet</unclear>
vs. Saml. &amp; Phillis.
</bibl>
<bibl type="case" xml:id="oscys.caseid.0011">7 Cr. 298 Queen vs Hepburn</bibl>

It seems like I would need to match on any bibl type=case which has an xml:id and is in <text>.

I'm going to go ahead and give this a shot, but I'm afraid we may see unexpected consequences, so we'll want to check carefully.

karindalziel commented 7 years ago

You can see the change on rosie, though - @kacinash please review.

http://rosie.unl.edu/earlywashingtondc/doc/oscys.case.0092.005

kacinash commented 7 years ago

@karindalziel Looks like it's working.

karindalziel commented 7 years ago

@kacinash - ok, this issue will stay open until that PR is reviewed (most likely by Jessica when she is back)

karindalziel commented 7 years ago

Will be fixed when https://github.com/CDRH/data_oscys/pull/25 is merged

jduss4 commented 5 years ago

Tested with https://cdrhdev1.unl.edu/earlywashingtondc/doc/oscys.case.0092.005 seems to be working