Print Stylesheets - Githubissues

CDRH / earlywashingtondc

OSCYS Rails site

http://earlywashingtondc.org

2 stars 0 forks source link

Print Stylesheets #203

Open karindalziel opened 7 years ago

karindalziel commented 7 years ago

This is actually an issue for all bootstrap sites (I suspect) but when you print OSCYS, it adds links after their text. This is probably OK for external links, but for internal links it does not help the user much. We could fix this in three ways:

Append the site URL to internal links
Append links only if they are external
remove all links in the print stylesheet

Thoughts?

(Karin also needs to add "no print" classes to the navigational type links like "Back to Families")

karindalziel commented 7 years ago

I am leaning towards appending links only if external, for all sites.

techgique commented 7 years ago

"Append site URL to internal links" Nooo! D: Please keep internal links all beginning with only /

I think only appending links if external will look nicer anyway. No need to print navigation links etc.

karindalziel commented 7 years ago

@techgique I mean when printing only with that option, not throughout the site's coding. To me, having a "(/people/per.000215)" after a person in the printed document does absolutely nothing, because the person would not know to add "http://earlywashingtondc.org" to it to make it work. If we prepended the site URL using CSS, the whole thing would print and the person could find the info if they wanted it.

I think, though, that once people get to the site itself, they won't need the external links anyway.

karindalziel commented 7 years ago

What remains to be seen is if I can even do the kind of conditional display I am talking about, so I need to research. Even then, it won't work in all browsers, so we should think about whether we want to default to "no links printed" or "all links printed."

techgique commented 7 years ago

@karindalziel Ah okay. The thought crossed my mind after posting that you may be able to do it with :before {content: ""}. That's a viable option :-)

Maybe set a class around the content elements so we only display links within the page content? And possibly add a class to external links on the back end if we only want to print links to other sites?

I'm not really sure what it's best to assume is the normal use case for someone printing these pages...

karindalziel commented 7 years ago

@techgique yeah I'm not sure either. Whatever we choose I'd like for it not to be on a case by case basis.

I will look into the feasibility of only appending external links to start with.