search

CDRH / lewisandclark

The Journals of the Lewis and Clark Expedition Rails Site
https://lewisandclarkjournals.unl.edu
1 stars 0 forks source link

Facet UI Update #132

Closed techgique closed 7 years ago

techgique commented 7 years ago

Closes #116

Questions: Do the titles and aria-labels make sense? Are we covering accessibility well? I'm not as familiar with aria attributes.

What do you think of the last commit to remove empty filter groups? Other option would be to gray them out to show they are disabled / won't change results, but that seemed more complicated to implement. Went with the quick option.

jduss4 commented 7 years ago

I'm not very familiar with aria labels, either, so I don't have any insightful comments unfortunately! I believe a few days ago that facet dropdowns were not created if there were no facet results returned, but I think I must have accidentally left that feature out when I redid them to use the Facets faux-model instead of the incoming parameters as their basis. I think leaving them out is fine!