search

CDRH / lewisandclark

The Journals of the Lewis and Clark Expedition Rails Site
https://lewisandclarkjournals.unl.edu
1 stars 0 forks source link

Design fix #189

Closed karindalziel closed 7 years ago

karindalziel commented 7 years ago

Fixed paragraph indentation on copyright page and reorganized CSS. More CSS organization is needed, but it's a start!

techgique commented 7 years ago

All looks good to me. Grouping into sections like that helps a lot!

I went through and did some further tweaking how I like to organize CSS/Sass. It shouldn't change anything with how it actually applies other than the change to the text-shadow on h1 elements. It increased the number of rules in dev tools CSS editor post-Sass compilation by two to 1337 rules. 😃

jduss4 commented 7 years ago

did you guys want me to look any of this over?

techgique commented 7 years ago

@karindalziel I remembered on my ride to work that there were a handful of border properties whose values were out of order. They have to be in the order border: width, style, color and quite a few had them out of order. I was already halfway through my last change and didn't separate them for their own commit. So it's possible we may see some borders where we previously hadn't.

karindalziel commented 7 years ago

@techgique I think as far as browsers are concerned the order doesn't matter (because browsers are used to interpreting sloppy css) so I've been needlessly sloppy - thanks for cleaning up, I'll be more consistent in the future!