search

CDRH / orchid

Rails Engine for site integration with CDRH API
MIT License
3 stars 0 forks source link

Continue work on facets with no labels #101

Closed jduss4 closed 5 years ago

jduss4 commented 5 years ago

There's an in-progress branch which should be investigated so we can decide if it needs more work or just to be a PR, etc: https://github.com/CDRH/orchid/tree/missing_labels

jduss4 commented 5 years ago

The in progress commit mentioned an issue where there were 25 of some item in the "no label" pile, but upon clicking it only 24 showed up in the search results. I haven't been able to replicate this issue, several months later, so I'm just going to put in a very basic PR to label facets that are an empty string, and not just a nil value.