search

CDRH / orchid

Rails Engine for site integration with CDRH API
MIT License
3 stars 0 forks source link

descriptive term list rather than li for metadata #213

Open jduss4 opened 3 years ago

jduss4 commented 3 years ago

Currently, our metadata looks like something:

<ul>
  <li><strong>Term:</strong> Text goes here</li>
</ul>

Perhaps this should instead use a dl / dt / dd solution. Consider pros and cons and accessibility

wkdewey commented 2 years ago

Dl/dt/dd is more semantically appropriate for metadata. Some accessibility concerns have been raised but overall it seems compatible with accessibility, see for instance MDN documentation

wkdewey commented 2 years ago

Note that Greg requested changes on the above PR