search

CDRH / orchid

Rails Engine for site integration with CDRH API
MIT License
3 stars 0 forks source link

Fix/favicon #224

Closed jduss4 closed 3 years ago

jduss4 commented 3 years ago

I worked on this last year and figure we should consider where it's at and if we want it in. I just tested locally and the files are being moved over appropriately by the generator, etc, so that's nice. It looks like there's a problem leftover from this commit: https://github.com/CDRH/orchid/commit/e51fd3b9351af5da1d572c01e3d8a61d34414c6e

jduss4 commented 3 years ago

Looking quickly at the first couple results, I'm guessing it was probably this one? https://realfavicongenerator.net/

techgique commented 3 years ago

On second thought, the colors probably don't matter since they'll be overwritten during design for each site. We might need to be careful about how this will affect existing sites' favicons though.