search

CDRH / orchid

Rails Engine for site integration with CDRH API
MIT License
3 stars 0 forks source link

Handling and displaying contents of nested fields #240

Open wkdewey opened 2 years ago

wkdewey commented 2 years ago

The code here https://github.com/CDRH/orchid/blob/0a86bd27f8aaaf48ff5af1b640253cd9aa6c0311/app/helpers/orchid/display_helper.rb, specificially the method def metadata_get_field_values, does not always work as intended with nested fields. It gives an error if the field is blank, and possibly in other circumstances.

wkdewey commented 1 year ago

This may have been fixed in the recent release but I am not sure

wkdewey commented 1 year ago

Looking at the Whitman site, I think these errors are no longer happening with nested fields and metadata