CDRH / sparc

Salmon Pueblo Archaeological Research Collection (SPARC) Rails Site
https://salmonpueblo.org/
0 stars 0 forks source link

Unit Search & Browse Overview Tab Breakout #160

Closed techgique closed 6 years ago

techgique commented 6 years ago

There was concern that the links in the Overview tab of a unit explore page is already growing large and to add links to all the associated tables would be too much, so the idea of adding a separate tab was proposed. We can query the tables for associated records to determine whether to display links to each of them or not. There is concern this would be costly time-wise, but we'll have to see when implementing it.

karindalziel commented 6 years ago

@techgique I think this, too is solved with the associated objects tab? https://cdrhdev3.unl.edu/explore/unit/064W/associated

jduss4 commented 6 years ago

His idea about checking whether there are any associated objects before displaying the link has not been implemented.

jduss4 commented 6 years ago

Work on associated objects checking is done on this branch: https://github.com/CDRH/sparc/tree/unit_links

concern about numbers reflecting unit.ceramic_vessels.count results being different from CeramicVessel.where(unit_no: "101W") since unit.ceramic_vessels uses features / strata to associate with objects

jduss4 commented 6 years ago

Because of changes to how the units are filtering the query results in PR #343 , I believe the numbers should be good to go now