CDRH / sparc

Salmon Pueblo Archaeological Research Collection (SPARC) Rails Site
https://salmonpueblo.org/
0 stars 0 forks source link

map views #25

Closed jduss4 closed 7 years ago

jduss4 commented 7 years ago

While on my map styling quest, I have come to the conclusion that the majority of the map svgs are functionally the same. The "early" maps hide some of the "later" map components, but they can be combined into the same svg file. So one thing to think about would be to condense the 7 maps into 1 rails view partial, which can then be included with differing styles depending on the occupation period.

Along the same lines, it would be very cool if a unit view showed the unit's position on a map. Which type of map would probably be determined by the occupation period. Right now the SVG's text would allow you to determine the unit "zone" but the overlaying "highlight" style polygon / path do not know about it. If we added some metadata to the map, we could easily display a small version of it with a highlighted zone to indicate the position of the currently viewed unit.

Thoughts?

karindalziel commented 7 years ago

That would indeed be super cool

wnmartin commented 7 years ago

Jessica, Hello. The parts "hidden" in the early map are because those components did not exist in the time-period that the map is to represent. So, condensing the maps is fine as long as the components appropriate to a given "occupation" periods can be shown without the other components.

Cheers, Worthy


From: Jessica Dussault [notifications@github.com] Sent: Tuesday, November 22, 2016 12:27 PM To: CDRH/sparc Subject: [CDRH/sparc] map views (#25)

While on my map styling quest, I have come to the conclusion that the majority of the map svgs are functionally the same. The "early" maps hide some of the "later" map components, but they can be combined into the same svg file. So one thing to think about would be to condense the 7 maps into 1 rails view partial, which can then be included with differing styles depending on the occupation period.

Along the same lines, it would be very cool if a unit view showed the unit's position on a map. Which type of map would probably be determined by the occupation period. Right now the SVG's text would allow you to determine the unit "zone" but the overlaying "highlight" style polygon / path do not know about it. If we added some metadata to the map, we could easily display a small version of it with a highlighted zone to indicate the position of the currently viewed unit.

Thoughts?

� You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/CDRH/sparc/issues/25, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMtvAMHXfvUdFrN0afvMlLXiwyCuh4NQks5rAyXkgaJpZM4K5t6g.

jduss4 commented 7 years ago

Hi Worthy, That's kind of what I'm thinking. There are groupings in the SVG with names like "sec-occupation" which are currently hidden in the early maps, so I think it would not be hard to keep that functionality going if we were going to combine the maps into pulling from the same template!

wnmartin commented 7 years ago

Jessica, Hello. Yes, the "same template" with "layers" that can be hide/show layers is great. Cheers, Worthy


From: Jessica Dussault [notifications@github.com] Sent: Tuesday, November 22, 2016 2:34 PM To: CDRH/sparc Cc: wnm; Comment Subject: Re: [CDRH/sparc] map views (#25)

Hi Worthy, That's kind of what I'm thinking. There are groupings in the SVG with names like "sec-occupation" which are currently hidden in the early maps, so I think it would not be hard to keep that functionality going if we were going to combine the maps into pulling from the same template!

� You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/CDRH/sparc/issues/25#issuecomment-262341997, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMtvAKJqyyQXJ-u4OlILvtCbfPoab8Jdks5rA0PIgaJpZM4K5t6g.

karindalziel commented 7 years ago

I believe this is done for now and we can add more map related issues as things come up.