search

CDU-data-science-team / nottshcMethods

An internal R package formalising common transformations, visualisations, and analyses of clinical data
https://cdu-data-science-team.github.io/nottshcMethods/
Other
4 stars 3 forks source link

Remove NHSRdatasets dependency #52

Closed Lextuga007 closed 2 years ago

Lextuga007 commented 2 years ago

Requires changing the vignette https://github.com/CDU-data-science-team/nottshcMethods/blob/main/vignettes/date_helper.Rmd to generating a table of dates but this is preferable to having a package dependency.

Lextuga007 commented 2 years ago

Rather than remove add this as suggests usethis::use_package("NHSRdatasets", "suggest")

ChrisBeeley commented 2 years ago

I was just looking at this dependency and not liking it! Can we remove?

Lextuga007 commented 2 years ago

Yes, I guess it's best to add a bit of dummy data instead as it's just an example showing the earliest and latest data functions.