CDU-data-science-team / pxtextminingdashboard

Text mining and visualization of NHS patient feedback.
https://feedbackmatters.uk/rsconnect/text_mining_dashboard/
Other
4 stars 1 forks source link

Popup window won't show #14

Open andreassot10 opened 3 years ago

andreassot10 commented 3 years ago

@ChrisBeeley you've fixed this before, but I've changed a few things and I'm completely lost again.

A popup window is activated when clicking on the facets in tab Sentiment Analysis -> Sentiment - text. It should contain info, but it's currently blank:

image

Running cat(str(tooltip_info)) (defined here) returns this:

Warning: Error in order: argument 1 is not a vector
  [No stack trace available]
tibble [1 x 13] (S3: tbl_df/tbl/data.frame)
 $ Comment number   : Factor w/ 60 levels "15074","8837",..: 1
 $ Feedback text tag: chr "Care/ Treatment"
 $ Feedback text    : chr "I have answered poor in response to question 7  however I believe the service in my case was very restricted du"| __truncated__
 $ anger            : int 15
 $ anticipation     : int 22
 $ disgust          : int 7
 $ fear             : int 16
 $ joy              : int 10
 $ negative         : int 31
 $ positive         : int 23
 $ sadness          : int 15
 $ surprise         : int 7
 $ trust            : int 19
tibble [0 x 13] (S3: tbl_df/tbl/data.frame)
 $ Comment number   : Factor w/ 60 levels "15074","8837",..: 
 $ Feedback text tag: chr(0) 
 $ Feedback text    : chr(0) 
 $ anger            : int(0) 
 $ anticipation     : int(0) 
 $ disgust          : int(0) 
 $ fear             : int(0) 
 $ joy              : int(0) 
 $ negative         : int(0) 
 $ positive         : int(0) 
 $ sadness          : int(0) 
 $ surprise         : int(0) 
 $ trust            : int(0)
ChrisBeeley commented 3 years ago

Sorry, I can't replicate the issue on the current branch (release 0.2.0), looks fine for me

:thinking:

Maybe a browser issue?

andreassot10 commented 3 years ago

I've tried the following:

  1. Personal laptop, R window: working
  2. Personal laptop, Firefox: working
  3. Work laptop, R window: working
  4. Work laptop, Chrome: NOT working
  5. Work laptop, Edge: working

In all five cases, the following warning is printed:

Warning: Error in order: argument 1 is not a vector
  [No stack trace available]
ChrisBeeley commented 3 years ago

I've got one theory. I'll try to replicate and test this morning

ChrisBeeley commented 3 years ago

I'm sorry I still can't replicate on my work machine with Chrome. It looks fine. Let's talk about it the three of us when we meet

andreassot10 commented 3 years ago

So it looks like it happens when my browser is zoomed in 110%!

The popup works in Chrome and Edge when zooming in from:

  1. 110% to 125%
  2. 125% to 150%
  3. 150% to 175%

Zooming out from 125% to 110% also works. But zooming in from 100% to 110% makes the data on the popup window disappear again.

Crazy! No idea how to resolve, really. A Shiny issue?

ChrisBeeley commented 3 years ago

It is quite fascinating. If you could file a reprex on {shiny} that would be really interesting. You may feel that you don't have time to do this, so whatever you think.

I think we should just ship it though, we can always go to 0.2.1 at a later stage, I'd like to get it out the door and worry about it later