search

CDrummond / bliss-mixer

GNU General Public License v3.0
4 stars 3 forks source link

Fix build action #5

Closed chincheta0815 closed 2 years ago

chincheta0815 commented 2 years ago

I changed the files needed for the build according to the build of bliss-analyser.

Therefore, I just left out the specific ARMv7 run. bliss-analyser does build all ARM in the same way as bliss-mixer now. Everything else is as it was.

In another commit I updated the debian image to bullseye as it is set in bliss-analyser.

I hope that helps building things.

CDrummond commented 2 years ago

Does this mean armv7 is no longer built? As that is required for older raspberries, AFAIK.

chincheta0815 commented 2 years ago

So far it is no longer build, yes. But: As far as I read the build for bliss-analyser it is also not build!? Correct me if I am wrong...

I am not that deep in all that stuff, but the old raspi's are only 32bit and need these "gnueabihf" binaries, the new ones are 64bit and need "aarch64" binaries. Looking into the Dockerfile that builds this dlecan image there is hardly the same used!? --> https://github.com/dlecan/rust-crosscompiler-arm/blob/master/arm/Dockerfile

Another thing that is not yet respected: How about i686? Is there no need for that anymore?

CDrummond commented 2 years ago

Ah, but docker-build.sh does invoke build arm-unknown-linux-gnueabihf arm-linux-gnueabihf-strip armhf-linux/bliss-mixer - so I assumed it still did. Hmmm... Must admit I copied this build stuff from Spotty.

32-bit ARM is required, as there are older 32-bit only Pi's still in use. i686 is legacy, so I'm not to bothered about that. But need to get 32-bit ARM working again.

chincheta0815 commented 2 years ago

Right now I think all necessary parts are build:

Only thing: I cannot test all of them I only have a Raspi 4.

CDrummond commented 2 years ago

OK, I'm not sure what the removed line actually did now! But I've performed a build, and all artefacts are there, so looks fine to me.

Thanks again.