search

CE-Programming / CEmu

Third-party TI-84 Plus CE / TI-83 Premium CE emulator, focused on developer features
https://ce-programming.github.io/CEmu/
Other
1.1k stars 78 forks source link

Fix MSVC Windows builds (and broken IRC links) #418

Closed programmer2514 closed 2 years ago

adriweb commented 2 years ago

Looks good to me, the dynamic builds were successful: https://github.com/CE-Programming/CEmu/actions/runs/1835120905 Let's just wait for @alberthdev's review I guess? Unless someone else says it's OK.

Anyway, the static builds need to be fixed or removed... In the meantime non-msvc static builds are available on https://jacobly.com/CEmu/master/CEmu64.exe

alberthdev commented 2 years ago

Anyway, the static builds need to be fixed or removed...

Haven't quite gotten back to it yet, but we would need another fresh build of static Qt to get things going again. (It's still a WIP, somewhat in hiatus...) Totally fine with disabling the static builds for now (if that's easy to do without completely removing them) until that's back in place again!

adriweb commented 2 years ago

I suppose you should clean your PR commits by rebasing?

adriweb commented 2 years ago

You should probably talk to us on the chan (#cemu-dev on IRC EFNet, or on Discord, the link is in the readme or maybe the toolchain's readme), it'll be simpler to organize the resting of your commits. BTW you should git rebase master your branch instead of merging to keep it up to date, if you want a cleaner commit history.

programmer2514 commented 2 years ago

Okay, will do. I was just messing around (probably should've made a new branch :/) and was planning to rebase once I actually did anything that worked. I'll hop into the Discord though, sorry for the mess

adriweb commented 2 years ago

I've run the action so you can take a look at what's failing now

programmer2514 commented 2 years ago

I actually have already fixed the dynamic builds again, and am currently automating building/deploying the latest static Qt5 whenever the corresponding artifacts are missing (see below). I'll merge it into master once I actually get it working (should save you the constant approval spam, and also keep the commit history cleaner).

Yeah, that's an old version. My latest changes can now be found in programmer2514:qt-build-automation until I actually get something working.

programmer2514 commented 2 years ago

Figured this might as well not stay open with broken commits until I actually get around to fixing it