search

CE-Programming / CEmu

Third-party TI-84 Plus CE / TI-83 Premium CE emulator, focused on developer features
https://ce-programming.github.io/CEmu/
Other
1.1k stars 78 forks source link

Add vertical printing to Keypress History #437

Closed TheLastMillennial closed 2 years ago

TheLastMillennial commented 2 years ago

I have found displaying the key presses history vertically is more readable for some. Although the window can already be made narrow, relying on word wrapping does not always successfully put each key press on a new line.

Example: Press [(] then [)] then [window]. It is currently impossible to have the parenthesis on new lines without [window] being cut off.

This pull request simply adds a check box to the Keypress History window which allows the user to toggle whether they want future key presses to word wrap or get put on a new line. Currently the state of the check box is not preserved after CEmu is closed. I would like to make it persistent in the future.

keyhistorywidget.cpp and keyhistorywidget.h have been edited to add a newline character "\n" to the beginning of a key, just before it's printed to the Keypress history.

Although CEmu.pro and CEmu.pro.qtds have been modified, they are specific to my build and can be omitted from this pull request.

This is my very first pull request. Please bear with me as I learn how to do these.

adriweb commented 2 years ago

Cool!

Typically what you want to do on your fork is to create another branch, with just the necessary changes (in this case, not the .pro-related modifications) and submit that. We can't really "choose" which (part of a) commit we merge or not from a PR - it will take all the new commits from your branch.