search

CE-Programming / CEmu

Third-party TI-84 Plus CE / TI-83 Premium CE emulator, focused on developer features
https://ce-programming.github.io/CEmu
Other
1.05k stars 77 forks source link

Localization incomplete on macOS menubar #450

Closed Jerry23011 closed 1 year ago

Jerry23011 commented 1 year ago

What's wrong, and with what software version?

Operating System: macOS 12.6.1 CEmu version: CEmu v2.0dev (git: 2a005b1) Describe your issue:
About CEmu doesn't show the translation even if it is localized, I tried all the languages, and the option in every language is displayed as English

Also, is it possible to make other options in the menu localizable, like Quit CEmu, Hide, and Hide Others, etc.

Screenshots

截屏2022-11-29 20 31 55
adriweb commented 1 year ago

We're probably missing some tr(...) here and there.

Jerry23011 commented 1 year ago

Anything I can do?

adriweb commented 1 year ago

I need to check on my side, but those may be Qt interacting with macOS standard stuff and it might not be the same way to translate those... Is your OS also in Chinese? I would expect it to be translated correctly if it was system-provided, but... I don't know, I need to dig into it more I guess.

Jerry23011 commented 1 year ago

Yes, my system is in Chinese, too. and it's very likely some of the strings are system-provided because some other apps who doesn't have Xcode as IDE also experience the same problem with options like Hide, Service, Hide Others. It shows in system settings that CEmu doesn't support languages other than English, so I suppose Qt doens't provide the option.

Jerry23011 commented 1 year ago

I just tested on Windows (Chinese version) and find the translations for About CEmu and Quit are all there, so I think it's likely to be Qt's problem.

adriweb commented 1 year ago

Alright, thanks for the tests! I'll check with Qt6 instead of Qt5, we'll see if they changed that...

adriweb commented 1 year ago

Alright can you try this ? (macOS 10.15 minimum) CEmu_qt6_macOS_test.zip

(it's codesigned, but you might have to do right-click > open, I don't remember)

Jerry23011 commented 1 year ago

I just tried it, and the translations are still not there. A new problem appeared, though. The keys are all stretched, especially the numbers, and that didn't appear with Qt 5

截屏2022-12-02 20 08 47
adriweb commented 1 year ago

ok, we'll keep that in mind if we ever switch to Qt6. Anyway, I guess I'll have to close this then, it's an external issue :(

Feel free to re-open if you know of a workaround, thanks!

Jerry23011 commented 1 year ago

Thanks a lot for testing it out. 🙏🏻

Jerry23011 commented 1 year ago

Hi, I think I found a string that is not localizable Version copied!, I can't reopen this issue for now, could you please reopen it, thanks

adriweb commented 1 year ago

well that's for another issue/PR, you can directly open a PR for that if you want :)

Basically tr("Version copied!") instead of "Version copied!", then the usual translation files updates (qm/ts)