CE-Programming / CEmu

Third-party TI-84 Plus CE / TI-83 Premium CE emulator, focused on developer features
https://ce-programming.github.io/CEmu
Other
1.05k stars 77 forks source link

Dark mode does not work on macOS #471

Closed SoCuul closed 12 months ago

SoCuul commented 12 months ago

What's wrong, and with what software version?

Operating System: macOS Ventura 13.5 CEmu version: CEmu v1.3 (git: 87c3b43) Describe your issue: Even though macOS dark mode is enabled, all UI elements appear in light mode.

What are the steps to reproduce this issue?

  1. Open CEmu and be faced with the bright UI elements haha

Any logs, error output, screenshot, other comments...?

image
adriweb commented 12 months ago

I think it only does that on a Qt5 build, with Qt6 it's all good. I should probably make the CI do that...

SoCuul commented 12 months ago

I think it only does that on a Qt5 build, with Qt6 it's all good. I should probably make the CI do that...

Are there any plans to publish a new release build anytime soon?

adriweb commented 12 months ago

When I get around to work on the Qt6 CI (maybe this weekend) it will show up in the nightly release which has binaries automatically updated at every commit.

SoCuul commented 12 months ago

Good to know!

adriweb commented 12 months ago

Ok so that was easy enough, and it is available here: https://github.com/CE-Programming/CEmu/releases/download/nightly/CEmu-nightly_mac_qt6.dmg ... but will only actually work as soon as I fix something that unexpectedly broke with a lib update a few days/weeks ago. Which should be hopefully soon, I've found a "solution" to the issue.

Edit: done!

adriweb commented 11 months ago

All good, it's ready on the download link I wrote before!

Dark mode as expected :)

image
SoCuul commented 11 months ago

How stable is the nightly build in this case?

adriweb commented 11 months ago

It's supposed to be considered stable, considering the master branch gets either small fixes/features, or major ones that have been worked on in another branch before being ready