search

CE-Programming / toolchain

Toolchain and libraries for C/C++ programming on the TI-84+ CE calculator series
https://ce-programming.github.io/toolchain/index.html
GNU Lesser General Public License v3.0
511 stars 54 forks source link

Change large if, elif chain of consecutive values in GetStringInput to one comparison #473

Closed myclevorname closed 8 months ago

myclevorname commented 8 months ago

What is with all of these magic values in this routine?

Also, please test this.

adriweb commented 8 months ago

You broke stuff apparently. Note that you could also have just run the tests yourselves like the CI does, to check locally before pushing.

make: Entering directory '/home/runner/work/toolchain/toolchain/CEdev/examples/standalone_examples/os_input'
/home/runner/work/toolchain/toolchain/CEdev/examples/standalone_examples/os_input/autotest.json loaded and verified. 4 unique tests found.
    [Test failed!] Hash #2 ("Test show user input") did not match any of the expected CRCs (got C3C4EC03).
    [Test failed!] Hash #3 ("Test output display") did not match the expected CRC F90F17BE (got B48F7D2).
[Autotest failed] Out of 4 tests attempted, 2 passed, and 2 failed.
myclevorname commented 8 months ago

I will fix this later today.

adriweb commented 8 months ago

calc84 thinks it's OK 👀