Open paquiteau opened 1 year ago
Sounds like a good plan to me @paquiteau!
Some other points to consider:
setup.py
and setup.cfg
to exclusively using a pyproject.toml
file, perhaps we can consider doing the same for ModOpt. Black can be configured directly in pyproject.toml
but requires additional tools for setup.cfg
.I mention the move to pyproject.toml
in point 8 ;) Setuping the pyproject.toml
should not be a big deal (I am getting pretty good at it and relies already on it for several of my projects, including pysap-fmri). this change of config file could happen simultaneously with the black formatting IMO.
Sorry I missed that, but since this is tied to the configuration of Black I think point 8 is linked to point 5 and should probably be done in conjunction.
I reckon that I have started multiple PRs, moving forward here is a proposition for the integration of this work.
I would recommend we use a squash+rebase strategie, to minimize the effect on the main trunk. To smooth things up here is what I propose:
(- [ ] 3. pull develop and merge the PnP PR (#265))--black
check. There should also be modification of isort ^1In a later future (e.g. start of Q2 2023), taking the opportunity of a coding sprint:
pyproject.toml
, and maybe use asrc
layout ^2, -> this seems to be the new standard ^3