search

CEA-COSMIC / pysap-astro

Other
0 stars 3 forks source link

[BUG] Missing sf_tools in requirements for the astro plugin #9

Closed tobias-liaudat closed 3 years ago

tobias-liaudat commented 4 years ago

System setup OS: macOS v10.15.1 Python version: 3.6.12 Python environment (if any): conda 4.7.12

Describe the bug The python package sf_tools is missing in the requirements for the astro plugin.

To Reproduce When doing: from pysap.plugins.astro.denoising.denoise import denoise

I got the error: ModuleNotFoundError: No module named 'sf_tools'

Module and lines involved

The sf_tools package is used in 'astro/denoising/noise.py', see: https://github.com/CEA-COSMIC/pysap-astro/blob/master/astro/denoising/noise.py

Are you planning to submit a Pull Request?

sfarrens commented 4 years ago

Thanks for spotting this @tobias-liaudat, I will open a PR to solve it.

sfarrens commented 3 years ago

Related to CEA-COSMIC/pysap#143

sfarrens commented 3 years ago

Resolved in #6