search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

Fix travis based on new pysap flow and add support to python3.8 #107

Closed chaithyagr closed 4 years ago

chaithyagr commented 4 years ago

1) With recent PR, we no longer need to add the binary file location (/extern/bin etc) to $PATH. This saves a lot of time and thus, pysap can be installed directly with pip install.

2) Also, added dependency to an internal released pynfft2 as the original pynfft was not released for quite some time and we would like to proceed with a release and not wait on them

3) Add python 3.8 for testing and overall move to testing on xenial as that corresponds to a higher ubuntu. Move time.clock() calls to time.perf_counter() calls to support python3.8

4) Remove support for n_jobs in ISAP wavelets due to erratic behavior.

5) Add a minute single documentation fix for #102. This resolves #102

Will open the PR for review once I have passing travis

chaithyagr commented 4 years ago

Yes, the circle CI is passing as it is testing on a cache, surprisingly, there is no way to force delete a cache, I have requested the support for this. Will merge soon..